Skip to content

Feature/song genres#6

Merged
alvarotorresc merged 18 commits into
mainfrom
feature/song-genres
Mar 3, 2026
Merged

Feature/song genres#6
alvarotorresc merged 18 commits into
mainfrom
feature/song-genres

Conversation

@alvarotorresc

Copy link
Copy Markdown
Owner

No description provided.

Show GenreBadge between artist and "Added by" when song has a genre.
Add SongCard component tests for genre badge rendering.
Add topGenre field to PastRound interface and render GenreBadge
in past rounds cards below the song/artist info.
Build artifacts in android/ were being linted unnecessarily.
console.error in catch blocks is legitimate error logging, not debug noise.
Substring matching caused false positives ("popular" matched "pop",
"countryside" matched "country"). Replaced with explicit aliases for
common Last.fm tag variants. Added tests for false-positive scenarios.
LASTFM_API_KEY is not exposed to client bundles (no PUBLIC_ prefix).
Genre detection was dead code in production. Now the server endpoint
detects genre and includes it as _detectedGenre in the response.
Validate genre against GENRES whitelist before Supabase insert to
prevent arbitrary strings. Add LASTFM_API_KEY to env validation schema.
- Add PastRounds tests (genre badge, empty state, scores, locale)
- Add SongCard tests (title/artist render, "Your track" state)
- Fix test assertions: toBeDefined -> toBeInTheDocument
- Fix test name: "capitalize" -> "render as-is" for unknown genres
- Replace loop with it.each in lastfm hip-hop variants
- Use GENRES.length instead of magic number 20
- Change odesli mock default to null for neutral behavior
@alvarotorresc alvarotorresc self-assigned this Mar 3, 2026
@netlify

netlify Bot commented Mar 3, 2026

Copy link
Copy Markdown

Deploy Preview for aux-music ready!

Name Link
🔨 Latest commit 9edae56
🔍 Latest deploy log https://app.netlify.com/projects/aux-music/deploys/69a6f5837dc6420008d3998d
😎 Deploy Preview https://deploy-preview-6--aux-music.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Resolve 9 conflicts from feature/android-capacitor merge:
- Combine expanded eslint ignores with no-console rule
- Merge capacitor deps with user-event dev dependency
- Add genre detection to server-side resolve with rate limiter
- Add topGenre to PastRound interface in useLeaderboard
- Add GenreBadge to expandable PastRounds component
- Add GenreFilter to tabbed LeaderboardView
- Add genre field to test factories (SongCard, useLeaderboard)
- Update AddSong tests for genre-aware signature
- Regenerate pnpm-lock.yaml
@alvarotorresc alvarotorresc merged commit 14ff0c5 into main Mar 3, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant